From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v8 01/15] vhost: add virtio packed virtqueue
	defines
Date: Fri, 6 Jul 2018 08:34:19 +0200
Message-ID: <04bb224e-258e-df2c-7d15-b3108345c4d2@redhat.com>
References: <20180705210741.17974-1-maxime.coquelin@redhat.com>
 <20180705210741.17974-2-maxime.coquelin@redhat.com>
 <20180706025249.GA13855@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
 mst@redhat.com, jasowang@redhat.com, wexu@redhat.com
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 7FD731BDFF
 for <dev@dpdk.org>; Fri,  6 Jul 2018 08:34:23 +0200 (CEST)
In-Reply-To: <20180706025249.GA13855@debian>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 07/06/2018 04:52 AM, Tiwei Bie wrote:
> On Thu, Jul 05, 2018 at 11:07:27PM +0200, Maxime Coquelin wrote:
>> From: Jens Freimann <jfreimann@redhat.com>
>>
>> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
>> ---
>>   lib/librte_vhost/vhost.h | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
>> index 79e3117d2..4fc804bd8 100644
>> --- a/lib/librte_vhost/vhost.h
>> +++ b/lib/librte_vhost/vhost.h
>> @@ -192,6 +192,26 @@ struct vhost_msg {
>>    #define VIRTIO_F_VERSION_1 32
>>   #endif
>>   
>> +/* Declare packed ring related bits for older kernels */
>> +#ifndef VIRTIO_F_RING_PACKED
>> +
>> +#define VIRTIO_F_RING_PACKED 34
>> +
>> +#define VRING_DESC_F_NEXT			1
>> +#define VRING_DESC_F_WRITE			2
>> +#define VRING_DESC_F_INDIRECT		4
>> +
>> +#define VRING_DESC_F_AVAIL			(1ULL << 7)
>> +#define VRING_DESC_F_USED			(1ULL << 15)
>> +
>> +struct vring_desc_packed {
> 
> Maybe vring_packed_desc will be more consistent with
> vring_packed_desc_event and vring_packed. Jason also
> planned to change the name to vring_packed_desc [1].
> 
> [1] https://lkml.org/lkml/2018/7/4/36

Thanks for the reminder, I fixed it in the series.

Regards,
Maxime
> 
> Best regards,
> Tiwei Bie
> 
>> +	uint64_t addr;
>> +	uint32_t len;
>> +	uint16_t id;
>> +	uint16_t flags;
>> +};
>> +#endif
>> +
>>   /*
>>    * Available and used descs are in same order
>>    */
>> -- 
>> 2.14.4
>>