From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Roger Keith" Subject: [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer. Date: Sun, 28 Sep 2014 05:28:44 +0000 Message-ID: <05E7C1C5-2730-4BE3-B808-6F69821F7898@windriver.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "" Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Check the FILE *f and rte_mempool *mp pointers for NULL and return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. Signed-off-by: Keith Wiles --- lib/librte_mempool/rte_mempool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_memp= ool.c index 332f469..0f71f10 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -765,6 +765,9 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp) unsigned common_count; unsigned cache_count; + RTE_VERIFY(f !=3D NULL); + RTE_VERIFY(mp !=3D NULL); + fprintf(f, "mempool <%s>@%p\n", mp->name, mp); fprintf(f, " flags=3D%x\n", mp->flags); fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); --=20 2.1.0 Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533