From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Wangyunjian\(wangyunjian,TongTu\)'" <wangyunjian@huawei.com>,
<dev@dpdk.org>
Cc: "'liwei \(DT\)'" <liwei395@huawei.com>,
"'xiawei \(H\)'" <xiawei40@huawei.com>
Subject: RE: txgbe: vlan offload setting errors
Date: Tue, 10 Dec 2024 10:00:03 +0800 [thread overview]
Message-ID: <05d001db4aa7$3a50f6a0$aef2e3e0$@trustnetic.com> (raw)
In-Reply-To: <10c5f65918a64c92ae3c1e104f655d43@huawei.com>
> -----Original Message-----
> From: Wangyunjian(wangyunjian,TongTu) <wangyunjian@huawei.com>
> Sent: Monday, December 9, 2024 8:30 PM
> To: dev@dpdk.org; jiawenwu@trustnetic.com; jianwang@trustnetic.com
> Cc: liwei (DT) <liwei395@huawei.com>; xiawei (H) <xiawei40@huawei.com>
> Subject: txgbe: vlan offload setting errors
>
> Hello everyone,
> I recently added a txgbe port and enabled vlan offload.
> However, when I checked the dpdk logs, I noticed the following error: "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set():
> Please stop port first."
You should stop the device first, since VLAN offload cannot be changed when Rx ring is enabled.
>
> Upon reviewing the txgbe pmd driver code, I discovered that the variable hw->adapter_stopped is initially set to 0 and is not
changed
> to 1 in the device initialization function (eth_txgbe_dev_init).
> This causes an error in the txgbe_vlan_offload_set function, which checks the value of adapter_stopped and reports an error when
it
> is 0.
It was set to 1 in txgbe_stop_hw().
>
> How can we fix this issue? Is it possible to set adapter_stopped to 1 in the eth_txgbe_dev_init function?
>
> Best regards,
> Wei Li
>
next prev parent reply other threads:[~2024-12-10 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8a4995861fb848aab7045c74949ae10b@huawei.com>
2024-12-09 12:30 ` txgbe: vlan offload setting errors Wangyunjian(wangyunjian,TongTu)
2024-12-10 2:00 ` Jiawen Wu [this message]
2024-12-10 6:12 ` Wangyunjian(wangyunjian,TongTu)
2024-12-10 6:21 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='05d001db4aa7$3a50f6a0$aef2e3e0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=dev@dpdk.org \
--cc=liwei395@huawei.com \
--cc=wangyunjian@huawei.com \
--cc=xiawei40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).