From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA38E7717D for ; Tue, 10 Dec 2024 02:00:10 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC00C40264; Tue, 10 Dec 2024 03:00:09 +0100 (CET) Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by mails.dpdk.org (Postfix) with ESMTP id BC62B4025A for ; Tue, 10 Dec 2024 03:00:07 +0100 (CET) X-QQ-mid: Yeas2t1733796004t453t42386 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [115.195.173.12]) X-QQ-SSF: 0000000000000000000000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 7100766536563524076 To: "'Wangyunjian\(wangyunjian,TongTu\)'" , Cc: "'liwei \(DT\)'" , "'xiawei \(H\)'" References: <8a4995861fb848aab7045c74949ae10b@huawei.com> <10c5f65918a64c92ae3c1e104f655d43@huawei.com> In-Reply-To: <10c5f65918a64c92ae3c1e104f655d43@huawei.com> Subject: RE: txgbe: vlan offload setting errors Date: Tue, 10 Dec 2024 10:00:03 +0800 Message-ID: <05d001db4aa7$3a50f6a0$aef2e3e0$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQJi7ww1w3hlOg2edSzo3W5Ldbvb3gG/VHdVscF0UvA= X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: M4ljHnpwRkMuzcO8ssIfr3BwyBMliQBtpLjW1REnmCOaisyq0yiaYIo5 z1pRgWgOoYeTwLZHr1AsYqIAw9/g5QH9+PFyZmSI2hY8TT748zcy5owrPYbAPhtojktZrxG 40r03izOUxW9tnd9+KNNRjlC3xQ3S+10uc34pxbwdUX2eSIqNLxAtPKMi5wUvZu4HNSmonM rfNtF5h6LfHkVS5hvDmNOzOkya29M6rIP1NpxaYS6svNOSG3DIVwUN5dB5Xtl5wuBsnMzQK eLmdFQkuk2u6zyfWCisowH/8pVdYTsjRQgC3DGCWDjsqH1Bz8RC+NoCAEhsB3feLU26DNMG 9ny+xBd8yKUzuX4vGov46QQdnREKQ1hRLz2ylJQ6LWjAdXaZzNOLX1flF201gS8aK/MgdmV RQF2J3AuxqBiHYepa+AF7bk2M910hN8exp8+Z+DBq8zx/8AwTnvxf4lthUyQ4NnVH2t975S 19XleGa3rxgOnVSGHT3Vsd6eLi2Hi7MYQLpbJ9ukkeROZxv8WMnltvrsk8r3gTQqndbsDiT 2DuXy4NdbUTf/gKrJtQ6V8Fpodz/DyAK09I3JMYV1LPMX/kHodbA6cYxPsLX7AgN3fMsZOx bwPacSxxV8IccXTNngkPYiDgfRjd6WXdKJs1m4bejzKQCvm0c93l+H8WtXK56OnhsqKEtES jU2ZhDDI+HFBpm8ehsZ9a9OWAIxJhYdynFS9Jtry5L1YOU+/POs187IoKWsU5qVygU0lDG0 8donNUEIAhXU9ZkHAwbnyWl4zkWUemMWYd/lBcvdYTq592fjCn58oMqejqEP8I++UUOVudC Nr23KficJOIcNZJIfyz0yYxTIRS2fZZ4US4JIhIXyBdDr/bT/hludKrZAuH2SlByGbBXzXL THDmfgGGrto6lBaSj9Db/EeKbekFb6vdsd0M5PDzeNEsKTbOS+XfIyo0RcIjUruy X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= X-QQ-RECHKSPAM: 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wangyunjian(wangyunjian,TongTu) > Sent: Monday, December 9, 2024 8:30 PM > To: dev@dpdk.org; jiawenwu@trustnetic.com; jianwang@trustnetic.com > Cc: liwei (DT) ; xiawei (H) > Subject: txgbe: vlan offload setting errors > > Hello everyone, > I recently added a txgbe port and enabled vlan offload. > However, when I checked the dpdk logs, I noticed the following error: "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set(): > Please stop port first." You should stop the device first, since VLAN offload cannot be changed when Rx ring is enabled. > > Upon reviewing the txgbe pmd driver code, I discovered that the variable hw->adapter_stopped is initially set to 0 and is not changed > to 1 in the device initialization function (eth_txgbe_dev_init). > This causes an error in the txgbe_vlan_offload_set function, which checks the value of adapter_stopped and reports an error when it > is 0. It was set to 1 in txgbe_stop_hw(). > > How can we fix this issue? Is it possible to set adapter_stopped to 1 in the eth_txgbe_dev_init function? > > Best regards, > Wei Li >