From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3C89CE7717F
	for <dpdk-dev@archiver.kernel.org>; Tue, 10 Dec 2024 06:21:26 +0000 (UTC)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6E9BE4029B;
	Tue, 10 Dec 2024 07:21:25 +0100 (CET)
Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216])
 by mails.dpdk.org (Postfix) with ESMTP id 9EE4D4025A
 for <dev@dpdk.org>; Tue, 10 Dec 2024 07:21:22 +0100 (CET)
X-QQ-mid: Yeas3t1733811679t670t29827
Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com
 [115.195.239.211])
X-QQ-SSF: 0000000000000000000000000000000
From: =?utf-8?b?Smlhd2VuIFd1?= <jiawenwu@trustnetic.com>
X-BIZMAIL-ID: 4743868789574139693
To: "'Wangyunjian\(wangyunjian,TongTu\)'" <wangyunjian@huawei.com>,
 <dev@dpdk.org>
Cc: "'liwei \(DT\)'" <liwei395@huawei.com>,
 "'xiawei \(H\)'" <xiawei40@huawei.com>
References: <8a4995861fb848aab7045c74949ae10b@huawei.com>
 <10c5f65918a64c92ae3c1e104f655d43@huawei.com>
 <05d001db4aa7$3a50f6a0$aef2e3e0$@trustnetic.com>
 <ca87267dbf9e44de8e06edfa55242df6@huawei.com>
In-Reply-To: <ca87267dbf9e44de8e06edfa55242df6@huawei.com>
Subject: RE: txgbe: vlan offload setting errors
Date: Tue, 10 Dec 2024 14:21:18 +0800
Message-ID: <061901db4acb$b968c7f0$2c3a57d0$@trustnetic.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: zh-cn
Thread-Index: AQJi7ww1w3hlOg2edSzo3W5Ldbvb3gG/VHdVAri8KAYB94wurLGcOuyg
X-QQ-SENDSIZE: 520
Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1
X-QQ-XMAILINFO: N2bAIxLK0elns8F4ywUkaS+/wUWyYyqOrpqWI5tbLxtLi8o63+OmHHqY
 /thSOnR3b2KB1fLjRrm8h+ecfPA2axjQ3ccoI7UWexPEmjKmNT0OW1yrK0eY2iRzk8JwrBg
 HdfDrgcMcn4UhSMn/WgDCrNZXg5XOmV5LuzSBwMoZJBUfeXFCMVNu9q/eqmJ5hSjY5D+iJ8
 Zlhf0yZAj/myJpSFTB4y6fnB464U0aFmHTUnf9Yq+FEd4y56WMpQ3vBAs+fDstl8BY9YlAn
 2p71zu0bslpLGIg9MzSKG1S8BzKkxiH7mNWiU/EozWMEFU/hlm51q1VaJfPqeiVM++GgRvm
 gIZteWgU+hbyTmH5Td0JbmuwVNEwYfmDSMF45+uCJtEzGB7DqIZ4BOxUQhvxHjGZUZfGbT1
 qu9fmlhf6gsxVRBvN4Y9+u93Pk2q/W2yd5cxXcPDKFgbVWD2PyAo7XUkabLvcjz4RCZzI0Q
 78tInyV48XZLvyBXr6I5xa+90aBzykXVJNDj6MzAyB20FtZzi6/2GWUjbd1c2u3JxOOsz1r
 C/eh4bcr7tWSkHjnaIg7kaK/vF6X9igi7RrRv9I8eUaN0cPz/IJwdCWi9L6xxGmCTd8nEFd
 uwEOyUIwK5e1Vgzk8RlZqKhX5AGc6MFqCSLfxvMQlRKo1Ud4DMQWcsIQR1t3cw2pwUKoVaR
 8cxsl4qTT4b++W16FKvfeJStdVE/4wThqOw+aM6DtAse+j7TEHOf0eP+WNkyU4x6TKT12oQ
 NCxZdu76DBzw3CfLp8efGX27Nr1/LeaDI9agfgNh01MpzNuZBNnGTkGPgHKkAcM3ZnCy1GB
 rczQR8kWFLA3fIPJECtHgsdqIHQ5xFNamlQx/YSBvQpfoPoBlUXAB64CmpCV8NV2rbMTf9g
 iN0LJ9qc1yE7pnDlLzcT8h3NRjEiXN/O7ANSTFV2krFRLroUOngJA74FBV/EsETl4q4WRwW
 P9b12f2DhLsuZog==
X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> > > Hello everyone,
> > > I recently added a txgbe port and enabled vlan offload.
> > > However, when I checked the dpdk logs, I noticed the following error:
> > > "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set():
> > > Please stop port first."
> >
> > You should stop the device first, since VLAN offload cannot be changed when Rx
> > ring is enabled.
> 
> However, I haven't start the port yet. The port is new added.

Enable VLAN offload, then start the device.
It will be configured in txgbe_vlan_offload_config(), which is not limited by
hw->adapter_stopped.