From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH v2] pdump: change to use generic
	multi-process channel
Date: Thu, 5 Apr 2018 19:17:20 +0800
Message-ID: <06200725-4df7-74a0-42eb-7e19d30c5874@intel.com>
References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com>
 <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A2C0302@irsmsx110.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 48B941CAF9
 for <dev@dpdk.org>; Thu,  5 Apr 2018 13:17:26 +0200 (CEST)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C0302@irsmsx110.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 4/5/2018 6:37 PM, Pattan, Reshma wrote:
> Hi,
>
>> -----Original Message-----
>> From: Tan, Jianfeng
>> Sent: Wednesday, April 4, 2018 4:08 PM
>> To: dev@dpdk.org
>> Cc: Tan, Jianfeng <jianfeng.tan@intel.com>; Pattan, Reshma
>> <reshma.pattan@intel.com>
>> Subject: [PATCH v2] pdump: change to use generic multi-process channel
>>
>> The original code replies on the private channel for primary and secondary
>> communication. Change to use the generic multi-process channel.
>>
>> Note with this change, dpdk-pdump will be not compatible with old version
>> DPDK applications.
>>
>> Cc: reshma.pattan@intel.com
>>
>> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>> ---
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 0c696f7..d55fd05 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -153,3 +153,7 @@ Deprecation Notices
>>     be added between the producer and consumer structures. The size of the
>>     structure and the offset of the fields will remain the same on
>>     platforms with 64B cache line, but will change on other platforms.
>> +
>> +* pdump: As we changed to use generic IPC, ``rte_pdump_set_socket_dir``
>> +will be
>> +  deprecated and removed in subsequent release; the parameter, path, of
>> +  ``rte_pdump_init`` will also be removed.
> Do we need to mention about deprecation of below enums too?
> enum rte_pdump_socktype {
>          RTE_PDUMP_SOCKET_SERVER = 1,
>          RTE_PDUMP_SOCKET_CLIENT = 2
> };

Nice catch, will add in next version.

Thanks,
Jianfeng

>
> Thanks,
> Reshma