From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] drivers/bonding: fix bond mac address reset Date: Fri, 15 Jun 2018 14:26:32 +0100 Message-ID: <06b8f88d-a256-d3a0-69db-52e2d38ec31c@intel.com> References: <20180523091121.9910-1-kiran.kokkilagadda@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Declan Doherty , Radu Nicolau , Chas Williams , kiran.kokkilagadda@caviumnetworks.com, dev@dpdk.org To: Chas Williams <3chas3@gmail.com> Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CAB191D618 for ; Fri, 15 Jun 2018 15:26:36 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/14/2018 9:38 PM, Chas Williams wrote: > > > On Thu, Jun 14, 2018 at 12:49 PM Ferruh Yigit > wrote: > > On 5/23/2018 10:11 AM, Kiran Kumar wrote: > > Currently when resetting bond mac address, we are getting the > > persisted mac address from slave info considering primary port > > as index. But we need to compare the port id from slave info > > with the primary port to get the primary slave index and get > > the persisted mac address. Without this fix, persisted mac addr > > will be zero and rte_eth_dev_default_mac_addr_set will fail. > > > > Fixes: a45b288ef21a ("bond: support link status polling") > > > > Signed-off-by: Kiran Kumar > > > Hi Declan, Radu, Chas, > > If there is no objection, the patch will be merged as it is. > Can you please check? > > > No objections. This patch looks correct. Applied to dpdk-next-net/master, thanks.