From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Subject: Re: [PATCH 05/11] net/sfc: add flow API filters support
Date: Tue, 7 Mar 2017 13:21:18 +0000 [thread overview]
Message-ID: <070b835f-918d-da6a-8aef-a658606e066a@intel.com> (raw)
In-Reply-To: <1488470591-5853-6-git-send-email-arybchenko@solarflare.com>
On 3/2/2017 4:03 PM, Andrew Rybchenko wrote:
> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
>
> Only pattern items VOID, ETH and actions VOID, QUEUE is now
> supported.
>
> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
<...>
> diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
> new file mode 100644
> index 0000000..0590756
> --- /dev/null
> +++ b/drivers/net/sfc/sfc_flow.c
> @@ -0,0 +1,693 @@
> +/*-
> + * Copyright (c) 2017 Solarflare Communications Inc.
> + * All rights reserved.
Missing "BSD LICENSE" line. This is same for all new files.
I think this discussed before, I don't know if that line is mandatory,
but can be good to have at least to be consistent to rest of the codes.
<...>
> +/*
> + * At now flow API is implemented in such a manner that each
> + * flow rule is converted to a hardware filter.
> + * All elements of flow rule (attributes, pattern items, actions)
> + * correspond to one or more fields in the efx_filter_spec_s structure
> + * that is responsible for the hardware filter.
> + */
> +
> +enum sfc_flow_item_layers {
> + SFC_FLOW_ITEM_ANY_LAYER = 0,
> + SFC_FLOW_ITEM_START_LAYER = 1,
> + SFC_FLOW_ITEM_L2 = 2,
> + SFC_FLOW_ITEM_L3 = 3,
> + SFC_FLOW_ITEM_L4 = 4,
> +};
No need to explicitly assign default values.
<...>
next prev parent reply other threads:[~2017-03-07 13:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:03 [PATCH 00/11] Support flow API in Solarflare PMD Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 01/11] net/sfc/base: split local MAC I/G back into separate flags Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 02/11] net/sfc/base: improve API to get supported filter matches Andrew Rybchenko
2017-03-07 13:25 ` Ferruh Yigit
2017-03-07 14:47 ` Andrew Rybchenko
2017-03-07 14:56 ` Ferruh Yigit
2017-03-02 16:03 ` [PATCH 03/11] net/sfc: implement dummy filter control callback Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 04/11] net/sfc: provide a way to check if filter is supported Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 05/11] net/sfc: add flow API filters support Andrew Rybchenko
2017-03-07 13:21 ` Ferruh Yigit [this message]
2017-03-09 15:29 ` Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 06/11] net/sfc: add VLAN in " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 07/11] net/sfc: add IPV4 " Andrew Rybchenko
2017-03-07 13:21 ` Ferruh Yigit
2017-03-02 16:03 ` [PATCH 08/11] net/sfc: add IPV6 " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 09/11] net/sfc: add TCP " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 10/11] net/sfc: add UDP " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 11/11] net/sfc: add unknown unicast/multicast match in flow API Andrew Rybchenko
2017-03-07 13:27 ` [PATCH 00/11] Support flow API in Solarflare PMD Ferruh Yigit
2017-03-07 14:56 ` Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 01/11] net/sfc/base: split local MAC I/G back into separate flags Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 02/11] net/sfc/base: improve API to get supported filter matches Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 03/11] net/sfc: implement dummy filter control callback Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 04/11] net/sfc: provide a way to check if filter is supported Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 05/11] net/sfc: add flow API filters support Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 06/11] net/sfc: add VLAN in " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 07/11] net/sfc: add IPV4 " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 08/11] net/sfc: add IPV6 " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 09/11] net/sfc: add TCP " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 10/11] net/sfc: add UDP " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 11/11] net/sfc: add unknown unicast/multicast match in flow API Andrew Rybchenko
2017-03-09 17:28 ` [PATCH v2 00/11] Support flow API in Solarflare PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=070b835f-918d-da6a-8aef-a658606e066a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Roman.Zhukov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox