From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] mk: fix permissions when using make install Date: Thu, 9 Aug 2018 18:10:44 +0100 Message-ID: <07127a19-8300-8c0c-41d1-2ec35bf36bbd@intel.com> References: <20180809152235.45376-1-bruce.richardson@intel.com> <2177083.Ak4RRs4Y8F@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org, dev@dpdk.org To: Thomas Monjalon , Bruce Richardson Return-path: In-Reply-To: <2177083.Ak4RRs4Y8F@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/9/2018 5:16 PM, Thomas Monjalon wrote: > 09/08/2018 17:22, Bruce Richardson: >> When using make install, the permissions of the resulting file should be >> those of the user using make install, not those of the user who ran the >> build. This would not be the case when a user explicitly runs: >> >> "make && sudo make install" >> >> Fix this by changing "cp -a", which preserves all attributes, to >> "cp -dR --preserve=timestamp", and by adding the flags >> "--no-same-owner --no-same-permissions" to the calls to tar. >> >> Fixes: 1fa0fd9d6b42 ("mk: allow to specify DESTDIR in build rule") >> Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree") >> Fixes: 576de42b83e5 ("doc: render and install man pages") >> >> CC: stable@dpdk.org >> Signed-off-by: Bruce Richardson > > Acked-by: Thomas Monjalon > > Applied, thanks Already applied, but to keep record: Tested-by: Ferruh Yigit