From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1 02/11] drivers/bus/ifpga: add function for
 AFU search by name
Date: Wed, 6 Mar 2019 12:44:47 +0000
Message-ID: <072f7969-ffab-d630-ae98-cfb0244b2dc8@intel.com>
References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com>
 <1551338000-120348-3-git-send-email-rosen.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: tianfei.zhang@intel.com, dan.wei@intel.com, andy.pei@intel.com,
 qiming.yang@intel.com, haiyue.wang@intel.com, santos.chen@intel.com,
 zhang.zhang@intel.com
To: Rosen Xu <rosen.xu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id E49E058C4
 for <dev@dpdk.org>; Wed,  6 Mar 2019 13:44:51 +0100 (CET)
In-Reply-To: <1551338000-120348-3-git-send-email-rosen.xu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/28/2019 7:13 AM, Rosen Xu wrote:
> In many scenarios, AFU is needed searched by name, this
> function add the feature.
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/bus/ifpga/ifpga_bus.c     | 13 +++++++++++++
>  drivers/bus/ifpga/rte_bus_ifpga.h |  3 +++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index 55d3abf..dfd6b1f 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -73,6 +73,19 @@ void rte_ifpga_driver_unregister(struct rte_afu_driver *driver)
>  	return NULL;
>  }
>  
> +struct rte_afu_device *
> +rte_ifpga_find_afu_by_name(const char *name)
> +{
> +	struct rte_afu_device *afu_dev = NULL;
> +
> +	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> +		if (afu_dev &&
> +			!strcmp(afu_dev->device.name, name))
> +			return afu_dev;
> +	}
> +	return NULL;
> +}

I can see this function called from drivers in following patches, did you test
this via shared library build? To be able to called from different library,
should this API needs to be added into .map file?

> +
>  static const char * const valid_args[] = {
>  #define IFPGA_ARG_NAME         "ifpga"
>  	IFPGA_ARG_NAME,
> diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h b/drivers/bus/ifpga/rte_bus_ifpga.h
> index 820eeaa..5762a33 100644
> --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> @@ -119,6 +119,9 @@ struct rte_afu_driver {
>  	return NULL;
>  }
>  
> +struct rte_afu_device *
> +rte_ifpga_find_afu_by_name(const char *name);

This is public header, can you please add function comments in doxygen format?