From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix stdout flush absence after printing stats Date: Wed, 20 Mar 2019 20:13:29 +0000 Message-ID: <08204589-8edf-01fd-73f1-92415a863ca8@intel.com> References: <1552908947-18120-1-git-send-email-arybchenko@solarflare.com> <8CEF83825BEC744B83065625E567D7C260D73800@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Igor Romanov , "stable@dpdk.org" To: "Iremonger, Bernard" , Andrew Rybchenko , "Lu, Wenzhuo" , "Wu, Jingjing" Return-path: In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D73800@IRSMSX108.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/20/2019 1:21 PM, Iremonger, Bernard wrote: > Hi Andrew, > >> -----Original Message----- >> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] >> Sent: Monday, March 18, 2019 11:36 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> >> Cc: dev@dpdk.org; Igor Romanov ; >> stable@dpdk.org >> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats >> >> From: Igor Romanov >> >> User can specify stats period(n). The statistics should be available to user >> every n second. But the print_stats() function does not force stdout to be >> flushed, so for instance, a user reading testpmd's stdout through pipe will >> not be able to read it untill the stdout buffer is filled. >> >> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") >> Cc: stable@dpdk.org >> >> Signed-off-by: Igor Romanov >> Signed-off-by: Andrew Rybchenko > > There is a checkpatch warning on the commit messge. > WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'? > > Otherwise > > Acked-by: Bernard Iremonger Applied to dpdk-next-net/master, thanks. (warning fixed while merging)