From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Raz Amir" <razamir22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3] pci: save list of detached devices,
	and re-probe during driver unload
Date: Tue, 10 Mar 2015 10:15:07 +0200
Message-ID: <084e01d05b0a$52f28350$f8d789f0$@gmail.com>
References: <1424932400-66862-1-git-send-email-razamir22@gmail.com>
 <1425467754-2693-1-git-send-email-razamir22@gmail.com>
 <84B1AA3E-21E4-4A41-ADEE-B37E27147243@gmail.com>
 <20150309102742.GA960@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "'Bruce Richardson'" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20150309102742.GA960@bricha3-MOBL3>
Content-Language: en-gb
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Sorry for that. Will send the new patch soon

-----Original Message-----
From: Bruce Richardson [mailto:bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org] 
Sent: 09 March 2015 12:28
To: Raz Amir
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3] pci: save list of detached devices, and re-probe
during driver unload

On Mon, Mar 09, 2015 at 10:07:29AM +0200, Raz Amir wrote:
> Hi, gentle reminder about this patch...
> 
> On Mar 4, 2015, at 1:15 PM, Raz Amir <razamir22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 
> Added code that saves the pointers to the detached devices, during 
> driver loading, and during driver unloading, go over the list, and 
> re-attach them by calling device_probe_and_attach on each device.
> 
> Signed-off-by: Raz Amir <razamir22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32 
> ++++++++++++++++++++++++++++----
> 1 file changed, 28 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c 
> b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> index 5ae8560..78e4dea 100644
> --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$");
> 
> #define MAX_BARS (PCIR_MAX_BAR_0 + 1)
> 
> +#define MAX_DETACHED_DEVICES    128
> +static device_t detached_devices[MAX_DETACHED_DEVICES] = {}; static 
> +int num_detached = 0;
> 
> struct nic_uio_softc {
>    device_t        dev_t;
> @@ -289,16 +292,37 @@ nic_uio_load(void)
> 
>        dev = pci_find_bsf(bus, device, function);
>        if (dev != NULL)
> -            for (i = 0; i < NUM_DEVICES; i++)
> -                if (pci_get_vendor(dev) == devices[i].vend &&
> -                        pci_get_device(dev) == devices[i].dev)
> -                            device_detach(dev);
> +            continue;
Since we have changed the body to be a continue statement, I think the
condition above needs to be flipped.

/Bruce