From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 0/5] consolidate testing apps to app dir Date: Wed, 20 Feb 2019 11:47:05 +0000 Message-ID: <089a7d55-c827-d4a9-2820-a5a160d0e2a6@intel.com> References: <20190125202642.66559-1-bruce.richardson@intel.com> <20190219145308.65668-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Bruce Richardson , dev@dpdk.org, thomas@monjalon.net Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 70241235 for ; Wed, 20 Feb 2019 12:47:08 +0100 (CET) In-Reply-To: <20190219145308.65668-1-bruce.richardson@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/19/2019 2:53 PM, Bruce Richardson wrote: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test, test-acl and test-pipeline build using meson is to > consolidate all these apps back into the app folder and use the logic > there. The bpf folder doesn't contain an actual application, but > rather example bpf code which can be loaded into testpmd. That is > possibly best moved to the examples folder, but I'm open to feedback > on the best place for it. > > With these changes, the "test" folder then becomes the location for > unit tests only. However, we can simplify things a little by moving > that too to the app folder, eliminating the need for the separate > "test-build" make target, and aligning the output folder for the > binary from "make test-build" with the source file location in app. I agree distinction between the "test" and "app" is not very clear, my motivation to split them was make building test code optional. But when split them we have a few cases that tests broken but not recognized for a while, since we don't have continuous integration that verifies tests perhaps it can be better to force developers to build them each time to detect issues. And as far as I understand this split is causing complications for adding meson support, if this will make easy to extend meson support overall patchset looks good to me. Thanks, ferruh > > --- > V2: * Following some discussion with Thomas, moved the autotests to the > app folder too. > * Updated maintainers file appropriately in each patch. > > Bruce Richardson (5): > test/cmdline_test: move to app directory > test/test-acl: move to app directory > test/test-pipeline: move to app directory > test/bpf: move to examples folder > test/test: move to app folder