From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 6/7] net/bnxt: fix some link related issues
Date: Thu, 29 Jun 2017 11:55:52 +0100
Message-ID: <096daf46-dd9f-f84b-de0d-9a4e87a8d461@intel.com>
References: <20170629025142.19404-1-ajit.khaparde@broadcom.com>
 <20170629025142.19404-7-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Stephen Hurd <stephen.hurd@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id D61432C2A
 for <dev@dpdk.org>; Thu, 29 Jun 2017 12:55:54 +0200 (CEST)
In-Reply-To: <20170629025142.19404-7-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/29/2017 3:51 AM, Ajit Khaparde wrote:
> This patch fixes some link related issues that can occur because:
> 
> bnxt_hwrm_port_phy_cfg() was setting enables inappropriately.
> bnxt_hwrm_port_phy_qcfg() was overly complex.
> bnxt_get_hwrm_link_config() was basing the speed on the link status.
> bnxt_get_hwrm_link_config() was using the incorrect macros for auto_mode
> we are not using supported speeds from phy_qcfg for auto mask.

Does it make sense to split patch per issue fixed?

> 
> Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
<...>