From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v2 09/11] mempool/dpaa: prepare to remove
 register memory area op
Date: Mon, 26 Mar 2018 10:13:03 +0300
Message-ID: <097cc6d4-f6fa-9934-a48a-775ba087d5bd@solarflare.com>
References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com>
 <1521994855-8808-1-git-send-email-arybchenko@solarflare.com>
 <1521994855-8808-10-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Olivier MATZ <olivier.matz@6wind.com>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com>
To: <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 069A4325F
 for <dev@dpdk.org>; Mon, 26 Mar 2018 09:13:10 +0200 (CEST)
In-Reply-To: <1521994855-8808-10-git-send-email-arybchenko@solarflare.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/25/2018 07:20 PM, Andrew Rybchenko wrote:
> Populate mempool driver callback is executed a bit later than
> register memory area, provides the same information and will
> substitute the later since it gives more flexibility and in addition
> to notification about memory area allows to customize how mempool
> objects are stored in memory.
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> v1 -> v2:
>   - fix build error because of prototype mismatch
>
>   drivers/mempool/dpaa/dpaa_mempool.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
> index 7b82f4b..0dcb488 100644
> --- a/drivers/mempool/dpaa/dpaa_mempool.c
> +++ b/drivers/mempool/dpaa/dpaa_mempool.c
> @@ -264,10 +264,9 @@ dpaa_mbuf_get_count(const struct rte_mempool *mp)
>   }
>   
>   static int
> -dpaa_register_memory_area(const struct rte_mempool *mp,
> -			  char *vaddr __rte_unused,
> -			  rte_iova_t paddr __rte_unused,
> -			  size_t len)
> +dpaa_populate(struct rte_mempool *mp, unsigned int max_objs,
> +	      char *vaddr, rte_iova_t paddr, size_t len,

Self NACK, 'void *vaddr' must be above

> +	      rte_mempool_populate_obj_cb_t *obj_cb, void *obj_cb_arg)
>   {
>   	struct dpaa_bp_info *bp_info;
>   	unsigned int total_elt_sz;
> @@ -289,7 +288,9 @@ dpaa_register_memory_area(const struct rte_mempool *mp,
>   	if (len >= total_elt_sz * mp->size)
>   		bp_info->flags |= DPAA_MPOOL_SINGLE_SEGMENT;
>   
> -	return 0;
> +	return rte_mempool_op_populate_default(mp, max_objs, vaddr, paddr, len,
> +					       obj_cb, obj_cb_arg);
> +
>   }
>   
>   struct rte_mempool_ops dpaa_mpool_ops = {
> @@ -299,7 +300,7 @@ struct rte_mempool_ops dpaa_mpool_ops = {
>   	.enqueue = dpaa_mbuf_free_bulk,
>   	.dequeue = dpaa_mbuf_alloc_bulk,
>   	.get_count = dpaa_mbuf_get_count,
> -	.register_memory_area = dpaa_register_memory_area,
> +	.populate = dpaa_populate,
>   };
>   
>   MEMPOOL_REGISTER_OPS(dpaa_mpool_ops);