From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues Date: Mon, 8 Oct 2018 12:00:41 +0100 Message-ID: <09bc1e17-661a-ab12-5ca0-215c7cdfe5ee@intel.com> References: <1538995285-2040-1-git-send-email-anoob.joseph@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Jerin Jacob , Narayana Prasad , dev@dpdk.org, Thomas Monjalon To: Anoob Joseph , Bruce Richardson , Pablo de Lara Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0FB4B1DB8 for ; Mon, 8 Oct 2018 13:00:44 +0200 (CEST) In-Reply-To: <1538995285-2040-1-git-send-email-anoob.joseph@caviumnetworks.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/2018 11:41 AM, Anoob Joseph wrote: > This patchset fixes multiple issues reported by checkpatch in l2fwd > code base. These issues would be flagged for any new copy of the file > and hence, fixing at the source. > > Anoob Joseph (8): > examples/l2fwd: remove quoted white space before newline > examples/l2fwd: need space between two args > examples/l2fwd: else should follow close brace > examples/l2fwd: replace bare usage of 'unsigned' > examples/l2fwd: follow convention for block comments > examples/l2fwd: limit line to 80 char > examples/l2fwd: space required between elements > examples/l2fwd: remove null initialisation Hi Anoob, I am not sure if it is good idea to get syntax only fixes, I would prefer to get syntax fixes when some other code touches that area. Thanks, ferruh