From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v5 4/5] vhost: unify message handling
	function signature
Date: Mon, 24 Sep 2018 16:54:44 +0100
Message-ID: <09c0daa0-7718-1bd2-93ce-2aa091e52466@intel.com>
References: <153780242838.17494.4512397995243433980.stgit@T460>
 <153780249865.17494.6292437035663379898.stgit@T460>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Nikolay Nikolaev <nicknickolaev@gmail.com>, maxime.coquelin@redhat.com,
 tiwei.bie@intel.com, zhihong.wang@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 7B85A5F13
 for <dev@dpdk.org>; Mon, 24 Sep 2018 17:54:49 +0200 (CEST)
In-Reply-To: <153780249865.17494.6292437035663379898.stgit@T460>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 24-Sep-18 4:21 PM, Nikolay Nikolaev wrote:
> Each vhost-user message handling function will return an int result
> which is described in the new enum vh_result: error, OK and reply.
> All functions will now have two arguments, virtio_net double pointer
> and VhostUserMsg pointer.
> 
> Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
> ---

<snip>

>   get_blk_size(int fd)
>   {
> @@ -127,27 +137,31 @@ vhost_backend_cleanup(struct virtio_net *dev)
>    * the device hasn't been initialised.
>    */
>   static int
> -vhost_user_set_owner(void)
> +vhost_user_set_owner(struct virtio_net **pdev __rte_unused,
> +		VhostUserMsg * msg __rte_unused)

Missed a few instances of using a typedef in this patch.

-- 
Thanks,
Anatoly