From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John Daley (johndale)" Subject: Re: [PATCH] net/enic: fix MAC address add and remove Date: Fri, 27 Jan 2017 19:04:57 +0000 Message-ID: <0a23266508ef4e008cc575b320b19f07@XCH-RCD-007.cisco.com> References: <20170126201212.31796-1-johndale@cisco.com> <2cb850e4-9bb7-327d-e380-c2ff6883d75e@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Ferruh Yigit Return-path: Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id A13CF28FD for ; Fri, 27 Jan 2017 20:04:59 +0100 (CET) In-Reply-To: <2cb850e4-9bb7-327d-e380-c2ff6883d75e@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, January 27, 2017 3:07 AM > To: John Daley (johndale) > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/enic: fix MAC address add and remove >=20 > On 1/26/2017 8:12 PM, John Daley wrote: > > The mac_addr_add callback function was simply replacing the primary > > MAC address instead of adding new ones and the mac_addr_remove > > callback would only remove the primary MAC form the adapter. Fix the > > functions to add or remove new address. Allow up to 64 MAC addresses > per port. > > > > Fixes: fefed3d1e62c ("enic: new driver") > > > > Signed-off-by: John Daley > > Reviewed-by: Nelson Escobar >=20 > Applied to dpdk-next-net/master, thanks. >=20 > (Since it is controversial that if this patch is a fix or implementing a = missing > feature (allow up to 64 MAC), I am getting patch as it is, but not CC'ed = to > stable tree, please shout if you disagree.) That's fine to not put it on stable. Thank you for applying. -john