From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] mk: fix kernel modules build dependency
Date: Thu, 29 Mar 2018 17:50:45 +0100
Message-ID: <0a59c197-0331-a122-f997-b8a77b39e01b@intel.com>
References: <20180329153931.26351-1-thomas@monjalon.net>
 <1556410.U3gqVypkhP@xps> <1b87dc99-c4a5-21d0-9d78-3ea024f6a0c4@intel.com>
 <2419180.MvykWTCLKm@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: hemant.agrawal@nxp.com, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 0DD0C2B96
 for <dev@dpdk.org>; Thu, 29 Mar 2018 18:50:48 +0200 (CEST)
In-Reply-To: <2419180.MvykWTCLKm@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/29/2018 5:43 PM, Thomas Monjalon wrote:
> 29/03/2018 18:38, Ferruh Yigit:
>> On 3/29/2018 5:32 PM, Thomas Monjalon wrote:
>>> 29/03/2018 17:48, Ferruh Yigit:
>>>> On 3/29/2018 4:39 PM, Thomas Monjalon wrote:
>>>>> Some kernel modules may need some header files to be "installed"
>>>>> in the build directory.
>>>>>
>>>>> When running multiple threads of make, kernel modules can try to
>>>>> be compiled before the lib headers are ready:
>>>>> 	make -j3
>>>>> 	kernel/linux/kni/kni_misc.c:19:37: fatal error:
>>>>> 		exec-env/rte_kni_common.h: No such file or directory
>>>>
>>>> Is there a reason to keep header in eal when module itself moved into kernel?
>>>
>>> It seems you missed my comment below:
>>>
>>> On a related note, this header file
>>>         lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>>> could be moved to lib/librte_kni/
>>> Opinion?
>>
>> Ahh, yes we are saying same thing.
>> But not sure if it should go under lib/librte_kni/ or kernel/linux/kni/?
>> I lean to kernel/linux/kni/.
> 
> Why in kernel/?
> 
> Logically, kernel/ depends on lib/ but not the reverse.
> 
> And regarding the licensing, we avoid BSD files in Linux modules.

>>From functionality point of view, module provides the functionality and it
should provide the header, this can be all subjective tough :)

Or in other words, if you have the kernel module, you can write another piece of
userspace application (without using librte_kni) and it will be functional.
But if you have the librte_kni only, it won't be functional on its own.

Providing header with kernel enables other userspace app to user KNI.