From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v5 05/11] net/virtio: dump packed virtqueue data Date: Wed, 12 Sep 2018 11:13:45 +0200 Message-ID: <0a9ea9b3-970d-906c-dd16-02e5690893dc@redhat.com> References: <20180906181947.20646-1-jfreimann@redhat.com> <20180906181947.20646-6-jfreimann@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: tiwei.bie@intel.com To: Jens Freimann , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id BF9F11041 for ; Wed, 12 Sep 2018 11:13:50 +0200 (CEST) In-Reply-To: <20180906181947.20646-6-jfreimann@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/06/2018 08:19 PM, Jens Freimann wrote: > Add support to dump packed virtqueue data to the > VIRTQUEUE_DUMP() macro. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtqueue.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 53fce61b4..531ba8c65 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -384,6 +384,12 @@ virtqueue_notify(struct virtqueue *vq) > uint16_t used_idx, nused; \ > used_idx = (vq)->vq_ring.used->idx; \ > nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ > + if (vtpci_packed_queue((vq)->hw)) { \ > + PMD_INIT_LOG(DEBUG, \ > + "VQ: - size=%d; free=%d; last_used_idx=%d;", \ > + (vq)->vq_nentries, (vq)->vq_free_cnt, nused); \ > + break; \ > + } \ > PMD_INIT_LOG(DEBUG, \ > "VQ: - size=%d; free=%d; used=%d; desc_head_idx=%d;" \ > " avail.idx=%d; used_cons_idx=%d; used.idx=%d;" \ > Reviewed-by: Maxime Coquelin Thanks, Maxime