From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] net/bonding: fix reset active slave Date: Fri, 22 Feb 2019 13:57:12 +0000 Message-ID: <0ac4d6db-3349-d5a6-3c5c-f31df682f510@intel.com> References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com> <4de12ce5-fda5-520c-22ea-d693c5b0c2cd@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Hari Kumar Vemula , dev@dpdk.org, "Pattan, Reshma" , JananeeX M , Declan , stable@dpdk.org To: Chas Williams <3chas3@gmail.com>, Hyong Youb Kim , Radu Nicolau Return-path: In-Reply-To: <4de12ce5-fda5-520c-22ea-d693c5b0c2cd@gmail.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/22/2019 1:52 AM, Chas Williams wrote: > > > On 2/20/19 10:16 AM, Hyong Youb Kim wrote: >> On Wed, Feb 20, 2019 at 02:56:36PM +0000, Radu Nicolau wrote: >>> >>> >>> On 2/20/2019 12:33 PM, Ferruh Yigit wrote: >>>> On 2/18/2019 3:58 PM, Radu Nicolau wrote: >>>>> >>>>> On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: >>>>>> test_alb_reply_from_client test fails due to incorrect active slave >>>>>> array's index. This was due to invalid active slave count. >>>>>> >>>>>> Count of internals->active_slave is not updated even when active slave >>>>>> is deactivated. >>>>>> Hence active slave count always keeps incrementing beyond the actual >>>>>> active slaves. >>>>>> >>>>>> Fix is to set the internals->active_slave to starting index 0 whenever >>>>>> it exceeds the number of slaves in active slave list and also update >>>>>> the active slave count during slave de-activation. >>>>>> >>>>>> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Hari Kumar Vemula >>>>>> --- >>>>>> >>>>> Acked-by: Radu Nicolau > Acked-by: Chas Williams Applied to dpdk-next-net/master, thanks.