From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 15/18] net/axgbe: add generic transmit and
 receive stats support
Date: Fri, 16 Mar 2018 17:47:20 +0000
Message-ID: <0b2e115f-f7a6-0978-55dd-c3845d3c2f91@intel.com>
References: <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-15-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id B38BB5F5F
 for <dev@dpdk.org>; Fri, 16 Mar 2018 18:47:35 +0100 (CET)
In-Reply-To: <1520584954-130575-15-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/9/2018 8:42 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> +static int
> +axgbe_dev_stats_get(struct rte_eth_dev *dev,
> +		    struct rte_eth_stats *stats)
> +{
> +	struct axgbe_rx_queue *rxq;
> +	struct axgbe_tx_queue *txq;
> +	unsigned int i;
> +
> +	for (i = 0; i < dev->data->nb_rx_queues; i++) {
> +		rxq = dev->data->rx_queues[i];
> +		stats->q_ipackets[i] = rxq->pkts;
> +		stats->ipackets += rxq->pkts;
> +		stats->q_ibytes[i] = rxq->bytes;
> +		stats->ibytes += rxq->bytes;
> +	}
> +	for (i = 0; i < dev->data->nb_tx_queues; i++) {
> +		txq = dev->data->tx_queues[i];
> +		stats->q_opackets[i] = txq->pkts;
> +		stats->opackets += txq->pkts;
> +		stats->q_obytes[i] = txq->bytes;
> +		stats->obytes += txq->bytes;
> +	}

Just as a reminder of imissed and ierror, it is OK if they are not ready to use
in this stage.

<...>