From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v6 08/11] net/mlx5: add hardware flow debug
 dump
Date: Thu, 26 Apr 2018 11:09:53 +0100
Message-ID: <0b2f69eb-9b66-f41a-d86b-9e3b51af9931@intel.com>
References: <20180420122340.113348-1-xuemingl@mellanox.com>
 <20180423123310.32991-9-xuemingl@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Xueming Li <xuemingl@mellanox.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id DBF4B7288
 for <dev@dpdk.org>; Thu, 26 Apr 2018 12:09:56 +0200 (CEST)
In-Reply-To: <20180423123310.32991-9-xuemingl@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/23/2018 1:33 PM, Xueming Li wrote:
> Dump verb flow detail including flow spec type and size for debugging
> purpose.

This patch is causing build errors [1], please test build with debug enabled.

Also set is already in next-net-mlx, fixed version needs to be updated there.

Thanks,
ferruh

[1]
...dpdk/drivers/net/mlx5/mlx5_rxq.c:1460:29: error: format specifies type
'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int')
[-Werror,-Wformat]
              hash_fields, tunnel, rss_level,
                                   ^~~~~~~~~

...dpdk/drivers/net/mlx5/mlx5_rxq.c:1599:23: error: format specifies type
'unsigned char' but the argument has type 'uint32_t' (aka 'unsigned int')
[-Werror,-Wformat]
                      hrxq->tunnel, hrxq->rss_level);
                                    ^~~~~~~~~~~~~~~

> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c  | 68 ++++++++++++++++++++++++++++++++++++-------
>  drivers/net/mlx5/mlx5_rxq.c   | 26 ++++++++++++++---
>  drivers/net/mlx5/mlx5_utils.h |  6 ++++
>  3 files changed, 86 insertions(+), 14 deletions(-)

<...>