From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [PATCH] net/bonding: stop and deactivate slaves when
 bonding port is stopped
Date: Thu, 2 Aug 2018 14:38:45 +0100
Message-ID: <0c16cb66-6ee4-ff2d-6d16-7a3fdd021b0c@intel.com>
References: <1533129523-1407-1-git-send-email-radu.nicolau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: chas3@att.com, stable@dpdk.org
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1533129523-1407-1-git-send-email-radu.nicolau@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 01/08/2018 2:18 PM, Radu Nicolau wrote:
> When a bonding port is stopped also stop and deactivate all slaves.
> Otherwise slaves will be still listed as active.
> 
> Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
>   drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 16105cb..960140c 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2229,12 +2229,15 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev)
>   			tlb_last_obytets[internals->active_slaves[i]] = 0;
>   	}
>   
> -	internals->link_status_polling_enabled = 0;
> -	for (i = 0; i < internals->slave_count; i++)
> -		internals->slaves[i].last_link_status = 0;
> -
>   	eth_dev->data->dev_link.link_status = ETH_LINK_DOWN;
>   	eth_dev->data->dev_started = 0;
> +
> +	internals->link_status_polling_enabled = 0;
> +	for (i = 0; i < internals->slave_count; i++) {
> +		internals->slaves[i].last_link_status = 0;
> +		rte_eth_dev_stop(internals->slaves[i].port_id);
> +		deactivate_slave(eth_dev, internals->slaves[i].port_id);
> +	}
>   }
>   
>   void
> 


Acked-by: Declan Doherty <declan.doherty@intel.com>