From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v10 04/19] vfio: remove uneccessary IPC for group fd clear Date: Mon, 9 Jul 2018 16:13:29 +0100 Message-ID: <0c85210f-7dd3-1e8c-648a-e64daf8cd710@intel.com> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180709033706.27858-1-qi.z.zhang@intel.com> <20180709033706.27858-5-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com To: Qi Zhang , thomas@monjalon.net Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 475221B452 for ; Mon, 9 Jul 2018 17:13:34 +0200 (CEST) In-Reply-To: <20180709033706.27858-5-qi.z.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-Jul-18 4:36 AM, Qi Zhang wrote: > Clear vfio_group_fd is not necessary to involve any IPC. > Also, current IPC implementation for SOCKET_CLR_GROUP is not > correct. rte_vfio_clear_group on secondary will always fail, > that prevent device be detached correctly on a secondary process. > The patch simply removes all IPC related stuff in > rte_vfio_clear_group. > > Signed-off-by: Qi Zhang > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly