From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 1/7] qede: add base driver
Date: Wed, 19 Apr 2017 16:19:31 +0100
Message-ID: <0d9df1f9-688f-e7ab-15c2-4288c700aaa8@intel.com>
References: <1461766722-7745-1-git-send-email-rasesh.mody@qlogic.com>
 <1461766722-7745-2-git-send-email-rasesh.mody@qlogic.com>
 <225ecab3-f6af-afaa-ec13-4f53d3f3b566@intel.com>
 <BLUPR0701MB1572A1118B7B8CF3248EAD899F320@BLUPR0701MB1572.namprd07.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>, DPDK <dev@dpdk.org>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>,
 "Patil, Harish" <Harish.Patil@cavium.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1221A37B1
 for <dev@dpdk.org>; Wed, 19 Apr 2017 17:19:32 +0200 (CEST)
In-Reply-To: <BLUPR0701MB1572A1118B7B8CF3248EAD899F320@BLUPR0701MB1572.namprd07.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

<...>

>>> +
>>> +#
>>> +# Add extra flags for base ecore driver files # to disable warnings
>>> +in them # # BASE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard
>>> +$(SRCDIR)/base/*.c))) $(foreach obj, $(BASE_DRIVER_OBJS), $(eval
>>> +CFLAGS+=$(CFLAGS_BASE_DRIVER)))
>>
>> My eyes just caught this one, above line adds $(CFLAGS_BASE_DRIVER)
>> many times to $(CFLAGS), but real intentions is add to obj specific CFLAGS
>> and only being limited to base files.
>>
>> Like:
>> $(foreach obj, $(BASE_DRIVER_OBJS), $(eval
>> CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
>>
>> Can you please fix this?
> 
> We will look into this, we plan to submit the fix as separate bug fix patch in 17.05 timeframe.

Reminder.

> 
> Thanks!
> -Rasesh
> 
>>
>> Fixing this may give some build errors on non-base driver files, although not
>> sure.
>>
>> Thanks,
>> ferruh