From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 1/2] bus/dpaa: fix incorrect ccsr mem
	allocation
Date: Thu, 28 Sep 2017 19:42:31 +0530
Message-ID: <0dc71a1b-9c8e-847c-ad08-3227a7dd8a1d@nxp.com>
References: <20170928123000.1711-1-shreyansh.jain@nxp.com>
 <20170928141045.21762-1-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0083.outbound.protection.outlook.com [104.47.42.83])
 by dpdk.org (Postfix) with ESMTP id 4E9AF107A
 for <dev@dpdk.org>; Thu, 28 Sep 2017 16:01:42 +0200 (CEST)
In-Reply-To: <20170928141045.21762-1-shreyansh.jain@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

On Thursday 28 September 2017 07:40 PM, Shreyansh Jain wrote:
> Fixes: 5ad2d123be48 "(bus/dpaa: introducing FMan configurations)"
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>   drivers/bus/dpaa/base/fman/fman.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c
> index 2c6029e..d0a8ee4 100644
> --- a/drivers/bus/dpaa/base/fman/fman.c
> +++ b/drivers/bus/dpaa/base/fman/fman.c
> @@ -242,11 +242,11 @@ fman_if_init(const struct device_node *dpa_node)
>   	if (!phys_addr) {
>   		FMAN_ERR(-EINVAL, "of_translate_address(%s, %p)\n",
>   			 mname, regs_addr);
> -			 __if->ccsr_map = mmap(NULL, __if->regs_size,
> -			 PROT_READ | PROT_WRITE, MAP_SHARED,
> -			 fman_ccsr_map_fd, phys_addr);
>   		goto err;
>   	}
> +	__if->ccsr_map = mmap(NULL, __if->regs_size,
> +			      PROT_READ | PROT_WRITE, MAP_SHARED,
> +			      fman_ccsr_map_fd, phys_addr);
>   	if (__if->ccsr_map == MAP_FAILED) {
>   		FMAN_ERR(-errno, "mmap(0x%"PRIx64")\n", phys_addr);
>   		goto err;
> 

While working on the v6, I missed two small changes. I have created 
patches against these and added the fixes. Can you please apply them?
(I didn't want to send a complete v7 just for these).

-
Shreyansh