From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH] crypto/openssl: fix that remove unneeded check Date: Tue, 10 Jan 2017 09:28:11 +0000 Message-ID: <0df6fc09-6d6e-f9fd-40e4-caae605469ff@intel.com> References: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org To: Piotr Azarewicz , pablo.de.lara.guarch@intel.com, dev@dpdk.org Return-path: In-Reply-To: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/01/17 14:45, Piotr Azarewicz wrote: > EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is > unneeded. > > Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") > > Signed-off-by: Piotr Azarewicz > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c > index 832ea1d..312154a 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -522,8 +522,7 @@ > if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <= 0) > goto process_cipher_decrypt_err; > > - if (EVP_CIPHER_CTX_set_padding(ctx, 0) <= 0) > - goto process_cipher_decrypt_err; > + EVP_CIPHER_CTX_set_padding(ctx, 0); > > if (EVP_DecryptUpdate(ctx, dst, &dstlen, src, srclen) <= 0) > goto process_cipher_decrypt_err; > Acked-by: Declan Doherty