From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH] examples/vm_power_manager: fix set VF MAC
	address
Date: Tue, 23 Jan 2018 14:32:39 +0000
Message-ID: <0e3713d3-b49e-401b-0fbe-ae1053ebb8fe@intel.com>
References: <1516716855-14805-1-git-send-email-david.coyle@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org
To: David Coyle <david.coyle@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1516716855-14805-1-git-send-email-david.coyle@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,

On 23/1/2018 2:14 PM, David Coyle wrote:
> Current code only sets mac address of first VF. Fix code so that it
> continues through the loop and sets the mac address of each VF.
>
> Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address of VF")
>
> Signed-off-by: David Coyle <david.coyle@intel.com>
> ---
>   examples/vm_power_manager/main.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
> index a50984d..a9f5ad1 100644
> --- a/examples/vm_power_manager/main.c
> +++ b/examples/vm_power_manager/main.c
> @@ -290,7 +290,7 @@ main(int argc, char **argv)
>   	for (portid = 0; portid < nb_ports; portid++) {
>   		struct ether_addr eth;
>   		int w, j;
> -		int ret = -ENOTSUP;
> +		int ret;
>   
>   		if ((enabled_port_mask & (1 << portid)) == 0)
>   			continue;
> @@ -308,8 +308,7 @@ main(int argc, char **argv)
>   		for (w = 0; w < MAX_VFS; w++) {
>   			eth.addr_bytes[5] = w + 0xf0;
>   
> -			if (ret == -ENOTSUP)
> -				ret = rte_pmd_ixgbe_set_vf_mac_addr(portid,
> +			ret = rte_pmd_ixgbe_set_vf_mac_addr(portid,
>   						w, &eth);
>   			if (ret == -ENOTSUP)
>   				ret = rte_pmd_i40e_set_vf_mac_addr(portid,

Acked-by: David Hunt <david.hunt@intel.com>