From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v3] vhost: add external message handling
 callbacks to the public API
Date: Mon, 21 Jan 2019 09:25:37 +0100
Message-ID: <0ecaf267-dd48-3ec5-c6dd-f23c802d160b@redhat.com>
References: <20190114042829.24499-1-dariusz.stojaczyk@intel.com>
 <20190117153226.72792-1-dariusz.stojaczyk@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: James R Harris <james.r.harris@intel.com>,
 Changpeng Liu <changpeng.liu@intel.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>, dev@dpdk.org,
 Zhihong Wang <zhihong.wang@intel.com>,
 Cunming Liang <cunming.liang@intel.com>, Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 0F809324D
 for <dev@dpdk.org>; Mon, 21 Jan 2019 09:25:46 +0100 (CET)
In-Reply-To: <20190117153226.72792-1-dariusz.stojaczyk@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 1/17/19 4:32 PM, Darek Stojaczyk wrote:
> External message callbacks are used e.g. by vhost crypto
> to parse crypto-specific vhost-user messages.
> 
> We are now publishing the API to register those callbacks,
> so that other backends outside of DPDK can use them as well.
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   lib/librte_vhost/rte_vhost.h           |  69 ++++++++++++++
>   lib/librte_vhost/rte_vhost_version.map |   1 +
>   lib/librte_vhost/vhost.c               |  13 +++
>   lib/librte_vhost/vhost.h               |  54 +----------
>   lib/librte_vhost/vhost_crypto.c        |  12 +--
>   lib/librte_vhost/vhost_user.c          | 123 +++++++++++++------------
>   6 files changed, 153 insertions(+), 119 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll apply it however only for v19.05 because API changes should
be submitted early in the release cycle (before -rc1, -rc2 at he
latest).

Thanks!
Maxime