From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 02/11] telemetry: add initial connection socket Date: Fri, 7 Sep 2018 10:48:19 +0100 Message-ID: <0ee49eec-35d8-caa1-0e79-067ffd08e475@intel.com> References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-3-git-send-email-ciara.power@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Ciara Power , harry.van.haaren@intel.com, brian.archbold@intel.com, emma.kenny@intel.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EE4A22AA0 for ; Fri, 7 Sep 2018 11:48:22 +0200 (CEST) In-Reply-To: <1535026093-101872-3-git-send-email-ciara.power@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 23-Aug-18 1:08 PM, Ciara Power wrote: > This patch adds the telemetry UNIX socket. It is used to > allow connections from external clients. > > On the initial connection from a client, ethdev stats are > registered in the metrics library, to allow for their retrieval > at a later stage. > > Signed-off-by: Ciara Power > Signed-off-by: Brian Archbold > --- Quick question: is there really a need for a separate thread? Can't you just register the socket as an interrupt, and just get a callback when something arrives? IPC works like that right now, i see no reason to not do it this way for telemetry? -- Thanks, Anatoly