From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2663C433E7 for ; Tue, 13 Oct 2020 13:11:16 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5054222EBE for ; Tue, 13 Oct 2020 13:11:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5054222EBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C15801DB2E; Tue, 13 Oct 2020 15:11:00 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 41B241DB28 for ; Tue, 13 Oct 2020 15:10:59 +0200 (CEST) IronPort-SDR: 3OOiAXJjttZbQyPfr/qtikCyP3khkCiH6NYmIyiaCQdYGQqYvdupJXYmKUdGP9YpQkOUlY98Fa vSy8XH3WEwcQ== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="145769477" X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="145769477" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 06:10:57 -0700 IronPort-SDR: 3MGncRL3aWaR4KaFPpycyKbj0vl+kFFMaczfdbsYgwBYQj+/k0jFDWG4Fl86InpaKvf0vj9P6s +5VJC3bK34og== X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="530389359" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 06:10:51 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com, Liron Himi , Stephen Hemminger , Ray Kinsella , Neil Horman , Rahul Lakkireddy , Gaetan Rivet , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Andrew Rybchenko References: <20200913220711.3768597-1-thomas@monjalon.net> <20201013100634.2482593-1-thomas@monjalon.net> <20201013100634.2482593-4-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <0effd469-ccbe-11ba-ef9b-53dd96e079b6@intel.com> Date: Tue, 13 Oct 2020 14:10:50 +0100 MIME-Version: 1.0 In-Reply-To: <20201013100634.2482593-4-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 3/3] ethdev: allow close function to return an error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 11:06 AM, Thomas Monjalon wrote: > The API function rte_eth_dev_close() was returning void. > The return type is changed to int for notifying of errors. > > If an error happens during a close operation, > the status of the port is undefined, > a maximum of resources having been freed. > > Signed-off-by: Thomas Monjalon > Reviewed-by: Liron Himi > Acked-by: Stephen Hemminger Reviewed-by: Ferruh Yigit