From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1] net/tap: explain how to compile eBPF C
	file
Date: Thu, 23 Aug 2018 13:09:50 +0100
Message-ID: <0f1ec67b-58f1-98ab-74bb-24e7f65f0d36@intel.com>
References: <1528733172-24747-1-git-send-email-ophirmu@mellanox.com>
 <HE1PR0501MB2314C552F39745ADFE788111D17F0@HE1PR0501MB2314.eurprd05.prod.outlook.com>
 <48f3aef6-765d-66d4-305c-541bd2aa3eb7@intel.com> <1566202.bke8Esm90b@xps>
 <09D1AFC9-52F2-49D6-A54B-76F8FCFB383F@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "Wiles, Keith" <keith.wiles@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, Ophir Munk <ophirmu@mellanox.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Pascal Mazon <pascal.mazon@6wind.com>,
 Olga Shern <olgas@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id C43784CA5
 for <dev@dpdk.org>; Thu, 23 Aug 2018 14:10:07 +0200 (CEST)
In-Reply-To: <09D1AFC9-52F2-49D6-A54B-76F8FCFB383F@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/5/2018 1:34 PM, Wiles, Keith wrote:
> 
> 
>> On Jul 4, 2018, at 3:11 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 04/07/2018 21:47, Ferruh Yigit:
>>> On 6/12/2018 3:02 PM, Ophir Munk wrote:
>>>> Please note that other than cloning iproute2 we also need to install clang and llvm tools versions 3.7 and upper.
>>>> Not sure there are clang and llvm packages of the required versions for the common distributions. 
>>>> I compiled the tools source code and installed them manually.
>>>
>>> Hi Keith, Thomas,
>>>
>>> What do you suggest on this patch?
>>>
>>> The "tap_bpf_program.c" is already withing the tap pmd this patch improves the
>>> doc about how to compile it, although it may not be so user friendly as Keith
>>> pointed, I believe better to get doc improvement here.
>>>
>>> And there is a code update "+#include "bpf_api.h", which includes a iproute2
>>> header, I am not sure about this one and how to manage this dependency.
>>
>> If you feel it needs some improvement, we can postpone it for 18.11.
>> The most important is to have a patch to reference when somebody asks.
>>
>> It can be improved and merged later, no pressure.
> 
> I agree.

Hi Ophir,

Are you planning a new version of patch for this release?

Thanks,
ferruh