From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: app/testpmd: add device removal
	command
Date: Fri, 25 Aug 2017 10:55:45 +0200
Message-ID: <100246790.r6DC0kRVUk@xps>
References: <1503499024-12480-1-git-send-email-rasland@mellanox.com>
 <2302304.eNG2ySBljJ@xps> <20170825075331.GB8124@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>,
 Raslan Darawsheh <rasland@mellanox.com>, jingjing.wu@intel.com,
 salehals@mellanox.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 869F37CFC
 for <dev@dpdk.org>; Fri, 25 Aug 2017 10:55:47 +0200 (CEST)
In-Reply-To: <20170825075331.GB8124@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/08/2017 09:53, Ga=EBtan Rivet:
> On Wed, Aug 23, 2017 at 06:18:34PM +0200, Thomas Monjalon wrote:
> > 23/08/2017 17:09, Ga=EBtan Rivet:
> > > Hello Raslan,
> > >=20
> > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> > > > Added hotplug in testpmd, to be able to test hotplug function
> > > > in the PMD's.
> > > >=20
> > > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> > [...]
> > > > --- a/app/test-pmd/cmdline.c
> > > > +++ b/app/test-pmd/cmdline.c
> > > > @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_r=
esult,
> > > >  			"port config (port_id|all) l2-tunnel E-tag"
> > > >  			" (enable|disable)\n"
> > > >  			"    Enable/disable the E-tag support.\n\n"
> > > > +
> > > > +			" device remove (device)\n"
> > > > +			"    Remove a device"
> > >=20
> > > I think it should still be a part of the "port" command set (port
> > > attach|detach|stop|close, etc).
> >=20
> > I tend to disagree.
> > As far as I know, we use port for ethdev or cryptodev.
> > Here we want to deal with EAL rte_device.
> >=20
>=20
> I see, that makes sense.
> I will redo the review with that in mind.

One option is to reword the command to show that it removes
the device associated to the specified port.