From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] nfp: copy pci info from pci to ethdev Date: Thu, 31 Mar 2016 15:27:44 +0200 Message-ID: <10027789.FxOxZF7KpY@xps13> References: <1458748296-15017-1-git-send-email-stephen@networkplumber.org> <20160325123117.GD18028@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Alejandro Lucero , Bruce Richardson To: Stephen Hemminger Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 84DB78D89 for ; Thu, 31 Mar 2016 15:29:38 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id f198so1248461wme.0 for ; Thu, 31 Mar 2016 06:29:38 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-29 08:16, Alejandro Lucero: > Hi guys, > > Sorry for the delay but I was on a Easter break. > > That patch is OK for me. In fact, I had one patch ready for upstreaming > with this change needed for supporting hotplug. I was waiting for some > feedback from one internal project needing this hotplug functionality > before submitting. [...] > > On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote: > > > The NFP driver (unlike other PCI devices) was not copying the pci info > > > from the pci_dev to the eth_dev. This would make the driver_name be > > > null (and other unset fields) when application uses dev_info_get. > > > > > > This was found by code review; do not have the hardware. > > > > > > Signed-off-by: Stephen Hemminger Applied, thanks