From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] Create kern folder for Linux kernel modules
Date: Fri, 22 Dec 2017 15:17:45 +0100
Message-ID: <10030168.6hk24mNXSe@xps>
References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com>
 <4919393.KhUSbVM1LT@xps> <E554161E-F956-4883-924F-9AA38F446C0C@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2AB561B38A
 for <dev@dpdk.org>; Fri, 22 Dec 2017 15:17:47 +0100 (CET)
In-Reply-To: <E554161E-F956-4883-924F-9AA38F446C0C@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/12/2017 14:59, Wiles, Keith:
> 
> > On Dec 22, 2017, at 5:38 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 
> > 22/12/2017 11:04, Hemant Agrawal:
> >> On 12/22/2017 2:13 PM, Thomas Monjalon wrote:
> >>> These modules are Linux modules, so they should be in the linuxapp dir.
> >> 
> >> 
> >> This is a cleaner separation w.r.t userspace/kernel space code.
> >> *kern* is a better placefolder for LKMs.
> > 
> > I prefer "kernel" name.
> 
> The name should be related to Linux in some way, like linux_kern or linux_kernel or linux_modules (this is the one I prefer) this way it make it clear which OS they are designed for.

If such top-level directory is created, the BSD modules must be moved there too.
That's why "kernel/" or "kernel/linux/" is appropriate.

> >> Also eal is not getting overloaded.
> >> 
> >> linuxapp is part of librte_eal.  KNI is not related to EAL, but still 
> >> the kni kernel code is added to librte_eal under linuxapp.
> > 
> > Yes it makes sense.
> > 
> > More opinions/votes?
> > 
> >>> There are also some kernel modules in the bsdapp directory.
> >> 
> >> We can move them as well.