From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH] examples/l2fwd-crypto: fix incorrect stats array length Date: Tue, 28 Jun 2016 09:28:32 +0100 Message-ID: <10043d7c-06c0-5877-c686-883baf87fa21@intel.com> References: <1467034665-30988-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Pablo de Lara , dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 30C672C34 for ; Tue, 28 Jun 2016 10:33:26 +0200 (CEST) In-Reply-To: <1467034665-30988-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27/06/16 14:37, Pablo de Lara wrote: > crypto_statistics array was not big enough for storing > all the possible crypto device statistics, as its size was > RTE_MAX_ETHPORTS, but should be RTE_CRYPTO_MAX_DEVS, leading > this to a potential out-of-bounds issue. > > Coverity issue: 120145 > > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") > > Signed-off-by: Pablo de Lara > --- > examples/l2fwd-crypto/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c > index 8dc616d..70fada5 100644 > --- a/examples/l2fwd-crypto/main.c > +++ b/examples/l2fwd-crypto/main.c > @@ -243,7 +243,7 @@ struct l2fwd_crypto_statistics { > } __rte_cache_aligned; > > struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS]; > -struct l2fwd_crypto_statistics crypto_statistics[RTE_MAX_ETHPORTS]; > +struct l2fwd_crypto_statistics crypto_statistics[RTE_CRYPTO_MAX_DEVS]; > > /* A tsc-based timer responsible for triggering statistics printout */ > #define TIMER_MILLISECOND 2000000ULL /* around 1ms at 2 Ghz */ > Acked-by: Declan Doherty