From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools: disable coloring of git-log output
Date: Mon, 19 Nov 2018 00:01:44 +0100
Message-ID: <10150003.XpIquesuWC@xps>
References: <20181023085217.18548-1-alialnu@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ali Alnubani <alialnu@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DD0D32B83
 for <dev@dpdk.org>; Mon, 19 Nov 2018 00:01:46 +0100 (CET)
In-Reply-To: <20181023085217.18548-1-alialnu@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/10/2018 10:52, Ali Alnubani:
> Colored git-log outputs will have escape characters
> appended to hashes, causing check-git-log.sh to fail
> with `error: malformed object name ?[33m<hash>?[m` when doing
> `git tag -l --contains <colored_hash>`.

I guess it is due to a config specifying to color "always".

> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> -git log --oneline --reverse $range |
> +git log --no-color --oneline --reverse $range |

There are a lot more "git log" calls in this script.
I wonder whether we should add this option everywhere.