From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v9 1/9] nfp: basic initialization
Date: Fri, 27 Nov 2015 10:18:46 +0100
Message-ID: <10228066.9OLyZAk2qB@xps13>
References: <1448531369-8808-1-git-send-email-alejandro.lucero@netronome.com>
 <20151126101449.3f450a14@xeon-e3>
 <CAD+H990Giq_7rbd-7mXoaQQiasii3MQv9R-zBstBPqgtNAPmpw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id D493A5A31
 for <dev@dpdk.org>; Fri, 27 Nov 2015 10:20:05 +0100 (CET)
Received: by wmvv187 with SMTP id v187so61856608wmv.1
 for <dev@dpdk.org>; Fri, 27 Nov 2015 01:20:05 -0800 (PST)
In-Reply-To: <CAD+H990Giq_7rbd-7mXoaQQiasii3MQv9R-zBstBPqgtNAPmpw@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-27 07:51, Alejandro Lucero:
> I converted (almost) all the Linux typedefs. This one went under the radar.
> 
> We do not have such thing like ixgbe/base but maybe it makes sense.
> 
> Should I send a new patchset version for fixing this "minor nit"?

If you send a new version, please fix the MAINTAINERS file update
(and squash the change with the doc patch).

PS: please answer below instead of top post.


> On Thu, Nov 26, 2015 at 6:14 PM, Stephen Hemminger <
> stephen@networkplumber.org> wrote:
> 
> > On Thu, 26 Nov 2015 09:49:21 +0000
> > Alejandro Lucero <alejandro.lucero@netronome.com> wrote:
> >
> > > +static inline void
> > > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val)
> > > +{
> > > +     uint32_t off;
> >
> > Minor nit. why mix use of Linux specific basic size typedefs (__u8)
> > with Posix standard values (uint32_t). The DPDK style is to use
> > the Posix types except in kernel drivers or code that is coming
> > from unified drivers (ie ixgbe/base)
> >