From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 2/7] drivers/net/e1000: Suppress
	misleading indentation warning
Date: Wed, 30 Mar 2016 19:12:39 +0200
Message-ID: <10236988.vM3noimEBN@xps13>
References: <1458682638-28378-1-git-send-email-aconole@redhat.com>
 <f7t60w412mr.fsf_-_@redhat.com> <20160330093653.0d7e1847@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Aaron Conole <aconole@redhat.com>, Panu Matilainen <pmatilai@redhat.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, dev@dpdk.org, "Richardson,
 Bruce" <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id B10E629CD
 for <dev@dpdk.org>; Wed, 30 Mar 2016 19:14:36 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id p65so192182133wmp.1
 for <dev@dpdk.org>; Wed, 30 Mar 2016 10:14:36 -0700 (PDT)
In-Reply-To: <20160330093653.0d7e1847@xeon-e3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-30 09:36, Stephen Hemminger:
> On Wed, 30 Mar 2016 10:06:36 -0400
> Aaron Conole <aconole@redhat.com> wrote:
> > --- a/drivers/net/e1000/Makefile
> > +++ b/drivers/net/e1000/Makefile
> > @@ -54,6 +54,9 @@ else
> >  #
> >  CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter
> >  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation
> > +endif
> >  endif
> 
> NAK, don't do it to the whole file.
> Fix the code (best option)
> or use a pragma for the small area which is broken for other reasons.

Stephen, your solutions do not work because Aaron has not been allowed
to modify this file.
As long as we are not allowed to modify the Intel base drivers,
I don't see any problem to hide some warnings in them.
The warnings could help us to clean the code or fix some bugs but
we are not allowed to...
It is the responsibility of the driver maintainer to keep this nasty code.