From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] net/octeontx: register fpa as platform HW mempool Date: Mon, 5 Feb 2018 18:55:12 +0000 Message-ID: <102db2bb-93c8-f731-f3a2-b5f66379107f@intel.com> References: <20180122154507.14617-1-pbhagavatula@caviumnetworks.com> <20180204153309.17312-1-pbhagavatula@caviumnetworks.com> <20180205114657.GB19776@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Pavan Nikhilesh , jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org To: Bruce Richardson Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B8F9C1B67E for ; Mon, 5 Feb 2018 19:55:15 +0100 (CET) In-Reply-To: <20180205114657.GB19776@bricha3-MOBL3.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/5/2018 11:46 AM, Bruce Richardson wrote: > On Mon, Feb 05, 2018 at 10:34:00AM +0000, Ferruh Yigit wrote: >> On 2/4/2018 3:33 PM, Pavan Nikhilesh wrote: >>> Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is >>> used. >>> >>> Signed-off-by: Pavan Nikhilesh >>> --- >>> >>> v2 Changes: >>> - fixed compilation issues caused by using experimental API in both meson and >>> make. >>> >>> drivers/net/octeontx/Makefile | 2 ++ >>> drivers/net/octeontx/meson.build | 2 ++ >> >> Meson patches are still going through the Bruce's tree. Can you please make this >> two separate patches (not patchset), I can get the driver one and Makefile, >> Bruce can get meson one. >> > Hi Ferruh, > > I disagree with this. Since the meson build is now merged into mainline, > many patches will have meson file changes to keep things building. These > patches should not go in the next-build tree but should be part of the > tree the rest of the patch targets. It should not be permitted to apply > a patch to next-net which breaks the meson build. > > Only patches which add new capabilities or drivers to the build system > will go in my tree. OK, so I will merge this with original patch. > > Regards, > /Bruce >