From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] mbuf: fix compile by making sched struct
	visible
Date: Mon, 14 Jan 2019 16:28:48 +0100
Message-ID: <103174099.zUeztqKWy2@xps>
References: <20190110180658.23302-1-harry.van.haaren@intel.com>
 <3EB4FA525960D640B5BDFFD6A3D891268E82929F@IRSMSX108.ger.corp.intel.com>
 <20190114145838.lqdq3c5y23wsr3hq@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>, "Dumitrescu,
 Cristian" <cristian.dumitrescu@intel.com>, "Pattan,
 Reshma" <reshma.pattan@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "gavin.hu@arm.com" <gavin.hu@arm.com>,
 "honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 75DE51B1EA
 for <dev@dpdk.org>; Mon, 14 Jan 2019 16:28:51 +0100 (CET)
In-Reply-To: <20190114145838.lqdq3c5y23wsr3hq@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/01/2019 15:58, Olivier Matz:
> On Fri, Jan 11, 2019 at 02:33:16PM +0000, Dumitrescu, Cristian wrote:
> > From: Van Haaren, Harry
> > > 
> > > Although C compilation works with the struct rte_mbuf_sched
> > > declared inside the struct rte_mbuf namespace, C++ fails to
> > > compile. This fix moves the rte_mbuf_sched struct up to the
> > > global namespace, instead of declaring it inside the struct
> > > mbuf namespace.
> > > 
> > > The struct rte_mbuf_sched is being used on the stack in
> > > rte_mbuf_sched_get() and as a cast in _set(). For this
> > > reason, it must be exposed as an available type.
> > > 
> > > Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field")
> > > 
> > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> > > 
> > > ---
> > > 
> > > v3:
> > >  - Update comment in mbuf to state size of struct sched (Crisitian)
> > > 
> > > v2:
> > >  - Different solution, not applicable, v3 based on v1 (ML discussion)
> > 
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Of course, final say belongs to Olivier, so Olivier please let un know your vote.
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks