From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/3] spinlock: add support for HTM lock
	elision for x86
Date: Wed, 17 Jun 2015 23:29:49 +0200
Message-ID: <10408699.ljKKKDUIsH@xps13>
References: <1433250693-23644-1-git-send-email-roman.dementiev@intel.com>
 <1434475006-13732-1-git-send-email-roman.dementiev@intel.com>
 <1434475006-13732-2-git-send-email-roman.dementiev@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Roman Dementiev <roman.dementiev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 8315AC4C2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 23:30:51 +0200 (CEST)
Received: by wibdq8 with SMTP id dq8so67825783wib.1
 for <dev@dpdk.org>; Wed, 17 Jun 2015 14:30:51 -0700 (PDT)
In-Reply-To: <1434475006-13732-2-git-send-email-roman.dementiev@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-16 10:16, Roman Dementiev:
> --- a/lib/librte_eal/common/include/arch/x86/rte_spinlock.h
> +++ b/lib/librte_eal/common/include/arch/x86/rte_spinlock.h
> @@ -39,6 +39,13 @@ extern "C" {
>  #endif
>  
>  #include "generic/rte_spinlock.h"
> +#include "rte_rtm.h"
> +#include "rte_cpuflags.h"
> +#include "rte_branch_prediction.h"
> +#include <rte_common.h>

Why using angle brackets for rte_common.h?

Introducing rte_cpuflags.h in this header breaks the compilation of
the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y.
Indeed, it triggers the -pedantic flag which is not supported by rte_cpuflags.h.
Maybe it's time to fix this header?