From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 1/1] eal/linux: change hugepage sorting to avoid overlapping memcpy Date: Wed, 02 Mar 2016 08:13:35 -0800 (PST) Message-ID: <10430327.MBS0Qdx8Wk@xps13> References: <568E77F3.8070408@intel.com> <1452178442-22154-1-git-send-email-ralf.hoffmann@allegro-packets.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ralf Hoffmann Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 71EAE677C for ; Wed, 2 Mar 2016 17:13:37 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so84829409wml.1 for ; Wed, 02 Mar 2016 08:13:37 -0800 (PST) In-Reply-To: <1452178442-22154-1-git-send-email-ralf.hoffmann@allegro-packets.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-07 15:54, Ralf Hoffmann: > with only one hugepage or already sorted hugepage addresses, the sort > function called memcpy with same src and dst pointer. Debugging with > valgrind will issue a warning about overlapping area. This patch changes > the sort method to qsort to avoid this behavior. The separate sort > function is no longer necessary. > > Signed-off-by: Ralf Hoffmann > Acked-by: Sergio Gonzalez Monroy Added ref to Jay Rolette and Applied, thanks