From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] test: fix broken "make test"
Date: Tue, 12 Feb 2019 12:24:33 +0100
Message-ID: <10690305.j51yestHYH@xps>
References: <20190211183859.12314-1-ramirose@gmail.com>
 <dcf845f7-3b67-2330-cb62-3c01ebfad4d6@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, naga.sureshx.somarowthu@intel.com, reshma.pattan@intel.com,
 dpdk-stable <stable@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Rami Rosen <ramirose@gmail.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <dcf845f7-3b67-2330-cb62-3c01ebfad4d6@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/02/2019 10:36, Ferruh Yigit:
> On 2/11/2019 6:38 PM, Rami Rosen wrote:
> > This patch fixes a broken build; when running
> > make test
> > we get the following error:
> > ...
> > Traceback (most recent call last):
> >   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
> >     num_fails = runner.run_all_tests()
> >   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
> > run_all_tests
> >     self.parallel_tests)
> >   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
> > __filter_test
> >     test_cmd = test["Command"]
> > KeyError: 'Command'
> > ...
> > The reason is that the pdump autotest entry uses "Comamnd"
> > instead of "Command"; this patch fixes it.
> > 
> > Bugzilla ID: 205
> > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Good catch! But it seems 19.02 released autotest broken, so this needs to be
> backported to 19.02:
> 
> Cc: stable@dpdk.org

Applied, thanks


> Thomas,
> What do you think adding autotest into DPDK community lab testing? I will bring
> the the suggestion in next meeting.

Yes, sure.
It has already been discussed but no task was created:
	https://bugs.dpdk.org/buglist.cgi?product=lab
Let's follow-up in next meeting.