From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 1/4] lib: add information metrics library
Date: Thu, 12 Jan 2017 20:05:22 +0100
Message-ID: <10847386.FvRstgEsi2@xps13>
References: <1484150594-3758-1-git-send-email-remy.horton@intel.com>
 <1951093.Zqtj2Qm3TA@xps13> <d68dcbe6-296f-aaed-3514-76a321db7c20@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id D3FA5558D
 for <dev@dpdk.org>; Thu, 12 Jan 2017 20:05:26 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id r144so35276758wme.1
 for <dev@dpdk.org>; Thu, 12 Jan 2017 11:05:26 -0800 (PST)
In-Reply-To: <d68dcbe6-296f-aaed-3514-76a321db7c20@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-12 15:30, Remy Horton:
> 
> On 12/01/2017 13:22, Thomas Monjalon wrote:
> > 2017-01-12 00:03, Remy Horton:
> [..]
> >> --- /dev/null
> >> +++ b/lib/librte_metrics/rte_metrics.h
> >> +/** Used to indicate port-independent information */
> >> +#define RTE_METRICS_NONPORT -1
> >
> > I do not understand this constant.
> > Why using the word "port" to name any device?
> > What means independent?
> 
> The metric library hold two sets of values: Ones specific to ports, and 
> ones that are global/aggregate. Agree "non port" is not the clearest 
> choice of name..

I think you should not use the word "port" at all.