From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 3/4] ethdev: move representor parsing
	functions
Date: Tue, 09 Oct 2018 15:25:27 +0200
Message-ID: <10928776.jD7b5uRBEX@xps>
References: <20181009021858.19216-1-thomas@monjalon.net>
 <20181009021858.19216-4-thomas@monjalon.net>
 <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com,
 ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 480701B4DC
 for <dev@dpdk.org>; Tue,  9 Oct 2018 15:25:30 +0200 (CEST)
In-Reply-To: <73ffc68e-0a1f-de2a-790e-6bd4941fddef@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/10/2018 14:38, Remy Horton:
> 
> On 09/10/2018 03:18, Thomas Monjalon wrote:
> > The functions for representor devargs parsing were static
> > in the file rte_ethdev.c.
> > In order to reuse them in the file rte_class_eth.c,
> > they are moved to the files ethdev_private.c/.h.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> There is overlap between these functions and some of the rte_kvargs_*() 
> functions. Is it feasible/desirable to combine them?

Yes!
This is what I wanted to suggest.
I think we should parse list and range as part of the kvargs library.
Would you be interested to rework those functions in a next release?