From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 5/9] pmdinfogen: move to drivers
	subdirectory
Date: Wed, 21 Jun 2017 12:00:24 +0200
Message-ID: <10937675.k8W90Yh6uJ@xps>
References: <cover.1496877060.git.gaetan.rivet@6wind.com>
 <8418992.7tWpiUoDtu@xps> <20170621094026.GD2344@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C10765583
 for <dev@dpdk.org>; Wed, 21 Jun 2017 12:00:25 +0200 (CEST)
In-Reply-To: <20170621094026.GD2344@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/06/2017 11:40, Ga=EBtan Rivet:
> On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote:
> > Another (probably better) solution is to keep basic definitions
> > and helpers in EAL:
> > 	- rte_pci.h keeps only some PCI definitions and helpers
> > like rte_pci_addr and eal_parse_pci_BDF() in EAL
> > 	- bus management is done in the PCI driver
> >=20
> > For pmdinfogen, we just need struct rte_pci_id.
> > Other tools or applications will probably need this kind of basic
> > struct and functions available in EAL.
>=20
> I mostly agree, this proposal should be kept to a minimum at first for
> this release and carefully expanded afterward.
>=20
> If that's ok, I will propose a new version of this patchset with a new
> librte_pci, that might fix both pmdinfogen and librte_kni.

Why creating a new librte_pci instead of just keeping it in EAL?