From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: remove exec-env directory
Date: Tue, 02 Apr 2019 12:03:14 +0200
Message-ID: <10947252.tCyXudDSDa@xps>
References: <20190401230712.31864-1-thomas@monjalon.net>
 <CAJFAV8yn97fs9rbCdEnwrk5FzSxLsrpd61LmOmoffLXGtvxQEQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
 Anand Rawat <anand.rawat@intel.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 99AD54C95
 for <dev@dpdk.org>; Tue,  2 Apr 2019 12:03:17 +0200 (CEST)
In-Reply-To: <CAJFAV8yn97fs9rbCdEnwrk5FzSxLsrpd61LmOmoffLXGtvxQEQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/04/2019 11:57, David Marchand:
> On Tue, Apr 2, 2019 at 1:07 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > Only one header file (rte_kni_common.h) was in the sub-directory
> >         include/exec-env/
> > This file was installed in a sub-directory of the same name.
> > Source and install directories are moved as below:
> >
> >    lib/librte_eal/linux/eal/include/exec-env/
> > -> lib/librte_eal/linux/eal/include/
> >
> >    build/include/exec-env/
> > -> build/include/
> >
> > The consequence is to have a file hierarchy a bit more flat.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  devtools/check-includes.sh                                     | 1 -
> >  kernel/linux/kni/kni_dev.h                                     | 2 +-
> >  kernel/linux/kni/kni_fifo.h                                    | 2 +-
> >  kernel/linux/kni/kni_misc.c                                    | 2 +-
> >  kernel/linux/kni/kni_net.c                                     | 2 +-
> >  lib/librte_eal/freebsd/eal/Makefile                            | 3 +--
> >  lib/librte_eal/linux/eal/Makefile                              | 3 +--
> >  .../linux/eal/include/{exec-env => }/rte_kni_common.h          | 0
> >  lib/librte_kni/rte_kni.c                                       | 2 +-
> >  lib/librte_kni/rte_kni.h                                       | 2 +-
> >  10 files changed, 8 insertions(+), 11 deletions(-)
> >  rename lib/librte_eal/linux/eal/include/{exec-env => }/rte_kni_common.h
> > (100%)
> >
> 
> Think you missed some bits in meson.
> lib/librte_eal/linux/eal/meson.build:install_subdir('include/exec-env',
> install_dir: get_option('includedir'))

You're right. I wonder how I have missed it!
In my poor understanding of meson, I think I just have to remove this line.