From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A649E77181 for ; Mon, 9 Dec 2024 12:30:13 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 336EF4025F; Mon, 9 Dec 2024 13:30:12 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id E9D064025D for ; Mon, 9 Dec 2024 13:30:09 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Y6LjV6Ymqz1kvkl; Mon, 9 Dec 2024 20:27:42 +0800 (CST) Received: from dggemv704-chm.china.huawei.com (unknown [10.3.19.47]) by mail.maildlp.com (Postfix) with ESMTPS id 1109E1A0188; Mon, 9 Dec 2024 20:30:06 +0800 (CST) Received: from kwepemn200006.china.huawei.com (7.202.194.129) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 9 Dec 2024 20:30:05 +0800 Received: from kwepemd500024.china.huawei.com (7.221.188.194) by kwepemn200006.china.huawei.com (7.202.194.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 9 Dec 2024 20:30:05 +0800 Received: from kwepemd500024.china.huawei.com ([7.221.188.194]) by kwepemd500024.china.huawei.com ([7.221.188.194]) with mapi id 15.02.1544.011; Mon, 9 Dec 2024 20:30:05 +0800 From: "Wangyunjian(wangyunjian,TongTu)" To: "dev@dpdk.org" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" CC: "liwei (DT)" , "xiawei (H)" Subject: txgbe: vlan offload setting errors Thread-Topic: txgbe: vlan offload setting errors Thread-Index: AdtKNXx1Xn6m+O8iR/CE1sVKf/HOugAAEb2w Date: Mon, 9 Dec 2024 12:30:05 +0000 Message-ID: <10c5f65918a64c92ae3c1e104f655d43@huawei.com> References: <8a4995861fb848aab7045c74949ae10b@huawei.com> In-Reply-To: <8a4995861fb848aab7045c74949ae10b@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.242.157] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello everyone,=20 I recently added a txgbe port and enabled vlan offload.=20 However, when I checked the dpdk logs, I noticed the following error: "2024= -12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set(): Please stop port fir= st."=20 Upon reviewing the txgbe pmd driver code, I discovered that the variable hw= ->adapter_stopped is initially set to 0 and is not changed to 1 in the devi= ce initialization function (eth_txgbe_dev_init).=20 This causes an error in the txgbe_vlan_offload_set function, which checks t= he value of adapter_stopped and reports an error when it is 0. How can we fix this issue? Is it possible to set adapter_stopped to 1 in th= e eth_txgbe_dev_init function?=20 Best regards, Wei Li